-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for parameterized classes (puppet 2.6+ support) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drwahl
wants to merge
22
commits into
bcarpio:master
Choose a base branch
from
drwahl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer take multiple classes on a single call (instead, use append for each class)
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a server that is likely to be more useful globally as the default mongodb_servers
…can be an empty host to inherit from
…oll over inheritance if one was not supplied
… script that handles adding, modifying, and removing hosts from the database. setup.py was really just adding hosts, so it has been replaced by mongodb_enc.py as well
…r.py. also handle missing inherits more gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sine puppet 2.6, classes can be parameterized. This pull request provides the setup.py and add_node.py the ability to store class parameters in the database. This change required that I removed the ability to supply multiple classes on a single pass, so to add more than one class, you will have to run the add_node.py (with -a append) or setup.py once for each class you wish to add. Below is an example of adding a parameterized class:
./setup.py -a new -c ntp -m servers=1.1.1.1
Which will return:
classes:
ntp:
servers:
- 1.1.1.1
Another example, but with adding multiple parameters for a single class:
./setup.py -a new -c ntp -m servers=1.1.1.1,servers=2.2.2.2,servers=192.168.1.1
Which will return:
classes:
ntp:
servers:
- 1.1.1.1
- 2.2.2.2
- 192.168.1.1
You can also add multiple parameters to a single class in one pass:
./setup.py -a new -c ntp -m servers=1.1.1.1,servers=2.2.2.2,servers=192.168.1.1 -m auth=disable -m broadcastclient
Which will return:
classes:
ntp:
auth:
- disable
servers:
- 1.1.1.1
- 2.2.2.2
- 192.168.1.1
A couple other minor changes: