APP : Add LoadingBar component to the App as replacement for LoadingS…#1122
APP : Add LoadingBar component to the App as replacement for LoadingS…#1122
Conversation
| > | ||
| <span class="text-sm text-zinc-500">Loading content...</span> | ||
| <LoadingSpinner class="h-4 w-4 text-zinc-500" /> | ||
| <!-- <LoadingSpinner class="h-4 w-4 text-zinc-500" /> --> |
There was a problem hiding this comment.
Please remove commented code
johan-bell
left a comment
johan-bell
left a comment
There was a problem hiding this comment.
Nice job @THISmann but remember to rebase to main
| @@ -9,6 +9,7 @@ import { ExclamationTriangleIcon } from "@heroicons/vue/24/outline"; | |||
| import ContentDisplayCard from "./ContentDisplayCard.vue"; | |||
| import { ref, watch } from "vue"; | |||
| import LoadingSpinner from "../LoadingSpinner.vue"; | |||
| > | ||
| <span class="text-sm text-zinc-500">Loading content...</span> | ||
| <LoadingSpinner class="h-4 w-4 text-zinc-500" /> | ||
| <!-- <LoadingSpinner class="h-4 w-4 text-zinc-500" /> --> |
THISmann
force-pushed
the
1010-app-add-loadingbar-component-to-the-app-as-replacement-for-loadingspinner
branch
from
7d6e4fc to
65f001d
Compare
MrDirkelz
left a comment
MrDirkelz
left a comment
There was a problem hiding this comment.
simplescreenrecorder-2025-10-10_08.25.17.mp4
This is some really great work @THISmann, it looks very "sleek".
I just have some comments, but the code and visuals mostly look good.
Maybe the light mode should be zinc color? As right now in light mode it looks very contrasted compared to the white/zinc background. Also we usually try to avoid gradients and usually just stick with a solid color, as it could impact performance, but this is perhaps a very small component that won't really impact performance that much. But not sure if we want it to look and feel like the cms loading bar as well so it is more clear on the progress of the loading?
But great work! Think it looks nice. We could even look into having "ghost" elements in the future. But that is something to think about later.
MrDirkelz
left a comment
MrDirkelz
left a comment
There was a problem hiding this comment.
Some tests are still failing
MrDirkelz
force-pushed
the
1010-app-add-loadingbar-component-to-the-app-as-replacement-for-loadingspinner
branch
from
7b61e53 to
a843f2f
Compare
johan-bell
left a comment
johan-bell
left a comment
There was a problem hiding this comment.
Nice job, But i highly recommand installing prettier and eslint to avoid useless formating. @THISmann
4 participants
…pinner