Implement a network changes notification to editContent.vue #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds real-time network change detection to EditContent.vue, suppressing alerts during local saves and displaying a warning badge when remote updates are detected.
- Introduces
liveContent,saveWasCalled, andnetworkChangesto detect and flag server-side updates. - Updates save logic to toggle
saveWasCalledand prevent false positives during local operations. - Adds a UI badge in the template to notify users of detected network changes.
Comments suppressed due to low confidence (3)
cms/src/components/content/EditContent.vue:112
- [nitpick] The name
networkChangesreads like an event or stream. Consider renaming tohasNetworkChangesornetworkChangesDetectedfor clearer boolean semantics.
const networkChanges = computed(() => {
cms/src/components/content/EditContent.vue:112
- There should be unit tests covering scenarios where
networkChangestoggles true/false—especially around local saves vs. remote updates—to prevent regressions.
const networkChanges = computed(() => {
cms/src/components/content/EditContent.vue:604
- [nitpick] Remove this interpolation of
saveWasCalledin the template; it appears to be debug code and isn’t intended for production UI.
{{ saveWasCalled }}
MrDirkelz
force-pushed
the
implement-network-changes-editcontent
branch
from
6121ddb to
582f095
Compare
MrDirkelz
force-pushed
the
implement-network-changes-editcontent
branch
from
582f095 to
3d5d85c
Compare
Collaborator
Author
|
There is a bug that I am not sure how to fix, will look for ideas from others during review |
Collaborator
|
@DirkDevelopmentFreelance What is the status on this ? |
Collaborator
Author
On hold till the DexieLiveQueryAsEditable has been implemented for EditCOntent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.