fix: Replace iframe with img tag to prevent pdf being downloaded auto… #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinxcode
added a commit
that referenced
this pull request
Dec 2, 2025
fix: Replace iframe with img tag to prevent pdf being downloaded auto…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open this PR to address "Loading home page downloads PDF instantly #52".
I replaced the
iframetag with animgtag so that the PDF is no longer embedded directly. In some browsers (such as Firefox), a PDF embedded in an iframe triggers an automatic download when the user’s default action is set to "Save File".Using a simple image preview avoids this issue.