Skip to content

DBC22-5275: made sure the useEffect can be fired when url path changed #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcgov-brwang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DBC22-5275: made sure the useEffect can be fired when url path changed #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
092fc3d
DBC22-5275: made sure the useEffect can be fired when url path changed
bcgov-brwang Jan 15, 2026
2e1823a
Merge branch 'main' into bugfix/DBC22-5275
bcgov-brwang Feb 2, 2026
5dc15f0
DBC22-5275: used mapRendered instead of location.search to update dis…
bcgov-brwang Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frontend/src/Components/map/Map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ export default function DriveBCMap(props) {
}

{searchedRoutes && searchedRoutes.length > 0 &&
<DistanceLabels updateRouteDisplay={updateRouteDisplay} mapRef={mapRef} isCamDetail={isCamDetail} />
<DistanceLabels updateRouteDisplay={updateRouteDisplay} mapRef={mapRef} isCamDetail={isCamDetail} mapRendered={mapRendered} />
}

{!!openPanel && largeScreen &&
Expand Down
6 changes: 3 additions & 3 deletions src/frontend/src/Components/routing/DistanceLabels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import distance from "@turf/distance";
// Styling
import './DistanceLabels.scss';

export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail }) {
export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail, mapRendered }) {
/* initialization */

// Redux
Expand All @@ -36,13 +36,13 @@ export default function DistanceLabels({ updateRouteDisplay, mapRef, isCamDetail

/* useEffect hooks */
useEffect(() => {
if (!mapRef || !mapRef.current) {
if (!mapRef || !mapRef.current || !mapRendered) {
return;
}

addDistanceOverlay();
updateRouteDisplay(selectedRoute);
}, [selectedRoute]);
}, [selectedRoute, mapRendered]);

/* Rendering */
// Threshold of 500 meters in distance by default
Expand Down
Loading