DBC22-5275: made sure the useEffect can be fired when url path changed#1175
Open
bcgov-brwang wants to merge 3 commits intomainfrom
Open
DBC22-5275: made sure the useEffect can be fired when url path changed#1175bcgov-brwang wants to merge 3 commits intomainfrom
bcgov-brwang wants to merge 3 commits intomainfrom
Conversation
ray-oxd
requested changes
Jan 30, 2026
Collaborator
ray-oxd
left a comment
ray-oxd
left a comment
There was a problem hiding this comment.
The root cause of this bug is a race condition where the map does not finish initializing before the useEffect block is ran. Adding location.search here causes the hook to run way too often is not desired.
Collaborator
Author
Update with mapRendered instead of using location.search |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.