Skip to content

psp-10863 | Cleaned up FeatureDataset object and refactored dependant code#5113

Open
FuriousLlama wants to merge 6 commits intobcgov:devfrom
FuriousLlama:features/psp-10863
Open

psp-10863 | Cleaned up FeatureDataset object and refactored dependant code#5113
FuriousLlama wants to merge 6 commits intobcgov:devfrom
FuriousLlama:features/psp-10863

Conversation

@FuriousLlama
Copy link
Collaborator

Removed repeated models similar to FeatureDataSet and improved inheritance
Cleaned components and refactor the use of PropertyForm and FeatureDataset
Refactored Property selection to have a clear separation of concerns
Standarized creation for files and the use of the property display
Cleaned up Map FSM to use only the data in requires

@FuriousLlama FuriousLlama self-assigned this Dec 9, 2025
@FuriousLlama FuriousLlama added the tech-debt Removing technical debt label Dec 9, 2025
import { IResponseWrapper } from '@/hooks/util/useApiRequestWrapper';
import { ApiGen_Concepts_PropertyOperation } from '@/models/api/generated/ApiGen_Concepts_PropertyOperation';
import { AxiosResponse } from 'axios';
import { ApiGen_Concepts_File } from '@/models/api/generated/ApiGen_Concepts_File';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import ApiGen_Concepts_File.
import { ApiGen_Concepts_PropertyOperation } from '@/models/api/generated/ApiGen_Concepts_PropertyOperation';
import { AxiosResponse } from 'axios';
import { ApiGen_Concepts_File } from '@/models/api/generated/ApiGen_Concepts_File';
import { FileForm, PropertyForm } from '../shared/models';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports FileForm, PropertyForm.
import { PropertyForm } from '../shared/models';
import ManagementContainer, { IManagementContainerProps } from './ManagementContainer';
import { IManagementViewProps } from './ManagementView';
import ManagementForm from './form/ManagementForm';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import ManagementForm.

import { FileForm, PropertyForm, WithFormProperties } from '../../models';
import PropertiesListContainer from './PropertiesListContainer';
import { PIMS_Property_Location_View } from '@/models/layers/pimsPropertyLocationView';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import PIMS_Property_Location_View.
import UpdatePropertiesContainer, {
IUpdatePropertiesContainerProps,
} from './UpdatePropertiesContainer';
import { IPropertiesListContainerProps } from './PropertiesListContainer';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import IPropertiesListContainerProps.
import React from 'react';
import { FormikProps, getIn } from 'formik';
import { PropertyForm, WithFormProperties } from '../../models';
import { map } from 'lodash';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import map.
import { WorklistContainer } from './WorklistContainer';
import { IWorklistViewProps } from './WorklistView';
import { ParcelDataset } from '../parcelList/models';
import { LocationFeatureDataset } from '@/components/common/mapFSM/useLocationFeatureLoader';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import LocationFeatureDataset.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech-debt Removing technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant