chore: remove enable-host-new-rental-unit-setup feature flag and related code#1012
Open
dimak1 wants to merge 4 commits intobcgov:mainfrom
Open
chore: remove enable-host-new-rental-unit-setup feature flag and related code#1012dimak1 wants to merge 4 commits intobcgov:mainfrom
dimak1 wants to merge 4 commits intobcgov:mainfrom
Conversation
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1012-1xvx2evz.web.app |
JazzarKarim
reviewed
Feb 2, 2026
strr-host-pm-web/app/components/form/DefineYourRental/UnitAddress.vue
Outdated
Show resolved
Hide resolved
JazzarKarim
reviewed
Feb 2, 2026
Collaborator
JazzarKarim
left a comment
JazzarKarim
left a comment
There was a problem hiding this comment.
I'm seeing a lot of files changing, is it all related to that FF?
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1012-1xvx2evz.web.app |
Collaborator
Author
|
@JazzarKarim these changes are to clean up the feature flag and related code that are no longer in use. To make it smaller PR I can only remove the feature flag, but then we'd have some dead code. |
dimak1
force-pushed
the
cleanup-feature-flag-3
branch
from
28d87c3 to
5b61ee4
Compare
|
Collaborator
|
Temporary Url for review: https://strr-hosts-dev--pr-1012-1xvx2evz.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
enable-host-new-rental-unit-setupfeature flag and related codeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License