-
Notifications
You must be signed in to change notification settings - Fork 9
SIMSBIOHUB-647: Create/Edit Observations Page #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1444 +/- ##
===========================================
- Coverage 47.57% 32.18% -15.40%
===========================================
Files 926 1053 +127
Lines 24182 66210 +42028
Branches 3609 2276 -1333
===========================================
+ Hits 11505 21307 +9802
- Misses 12043 44410 +32367
+ Partials 634 493 -141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
app/src/features/surveys/observations/create/CreateObservationPage.tsx
Outdated
Show resolved
Hide resolved
I pushed up a few misc changes. Mostly just some component cleanup and addressing a few react dependency complaints, etc. |
a9ff7b5
to
def7139
Compare
wip wip: create location and date sections on form wip: style subcount form wip: adding measurements to subcounts add dual autocomplete subcount form subcount table on create observation page fix measurement search show measurement options in subcount table on create observation page wip: formik validation add subcount sign placeholder to create request wip: environments incorrectly formatted in handlesubmit fix incorrect key fix environments on create observations page fix measurement interfaces SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page (#1459) Add Pagination to System Alerts on Admin Page --------- Co-authored-by: Nick Phura <nickphura@gmail.com> Update CSV Error Import Dialog Styling (#1456) - update csv import error dialog - replace failure snackbar & add frontend pagination to csv import errors BugFix: Fix Type for Capture Attachments (#1460) - modifying critter index file --------- Co-authored-by: Macgregor Aubertin-Young <macgregor.aubertin-young@gov.bc.ca> Co-authored-by: Macgregor Aubertin-Young <108430771+mauberti-bc@users.noreply.github.com> BugFix: Method Attributes SQL (#1462) - fix sql Added DualAutocompleteUnitField.tsx to help reduce the size of the DualAutocompleteField.tsx. Renamed some of the dual autocomplete field props, just to make them more consistent/predictable. Fixed missing props in create/edit technique vantages (missing category data type prop). Add formik snackbar error component to observation form. Addressed a few react missing dependency warnings. Update missed jsdoc comments. Update missed jsdoc comments 2. WIP: Add create observation sampling fields. Working sampling fields. Enhancements to sampling fields
e0b3dde
to
4683f3f
Compare
- WIP: observation db migrations. - Add database-models.
Fix subcount types. Fix existing unit tests.
Looks great! Some additions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create and edit seem to be working correctly!
Links to Jira Tickets
Description of Changes
Testing Notes