Skip to content

SIMSBIOHUB-647: Create/Edit Observations Page #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Mar 24, 2025
Merged

SIMSBIOHUB-647: Create/Edit Observations Page #1444

merged 58 commits into from
Mar 24, 2025

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Dec 3, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Allows observations to be added from a dedicated page
  • Allows observations to be edited from a dedicated page

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 10.17812% with 2824 lines in your changes missing coverage. Please review.

Project coverage is 32.18%. Comparing base (24f9b5a) to head (19b0a47).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eys/observations/form/edit/EditObservationPage.tsx 0.00% 300 Missing ⚠️
...observations/form/create/CreateObservationPage.tsx 0.00% 212 Missing ⚠️
...s/observations/form/components/ObservationForm.tsx 0.00% 189 Missing ⚠️
...nts/sampling/hooks/useSamplingInformationCache.tsx 0.59% 168 Missing ⚠️
...ents/environments/environment/EnvironmentField.tsx 0.00% 140 Missing ⚠️
...ations/form/components/subcounts/SubcountsForm.tsx 0.00% 140 Missing ⚠️
.../dual-autocomplete-field/DualAutocompleteField.tsx 0.00% 93 Missing ⚠️
...ys/observations/form/components/subcounts/utils.ts 0.00% 77 Missing ⚠️
...nents/environments/ObservationEnvironmentsForm.tsx 0.00% 65 Missing ⚠️
...s/observation-repository/observation-repository.ts 3.07% 63 Missing ⚠️
... and 79 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1444       +/-   ##
===========================================
- Coverage   47.57%   32.18%   -15.40%     
===========================================
  Files         926     1053      +127     
  Lines       24182    66210    +42028     
  Branches     3609     2276     -1333     
===========================================
+ Hits        11505    21307     +9802     
- Misses      12043    44410    +32367     
+ Partials      634      493      -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mauberti-bc mauberti-bc added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Not Ready For Review Addressing feedback and/or refactoring labels Jan 8, 2025
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jan 16, 2025
@NickPhura
Copy link
Collaborator

I pushed up a few misc changes. Mostly just some component cleanup and addressing a few react dependency complaints, etc.

@NickPhura NickPhura added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Ready For Review PR is ready for review labels Jan 20, 2025
mauberti-bc and others added 2 commits January 21, 2025 10:06
wip

wip: create location and date sections on form

wip: style subcount form

wip: adding measurements to subcounts

add dual autocomplete

subcount form

subcount table on create observation page

fix measurement search

show measurement options in subcount table on create observation page

wip: formik validation

add subcount sign placeholder to create request

wip: environments incorrectly formatted in handlesubmit

fix incorrect key

fix environments on create observations page

fix measurement interfaces

SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page (#1459)

Add Pagination to System Alerts on Admin Page

---------

Co-authored-by: Nick Phura <nickphura@gmail.com>

Update CSV Error Import Dialog Styling (#1456)

- update csv import error dialog
- replace failure snackbar & add frontend pagination to csv import errors

BugFix: Fix Type for Capture Attachments (#1460)

- modifying critter index file

---------

Co-authored-by: Macgregor Aubertin-Young <macgregor.aubertin-young@gov.bc.ca>
Co-authored-by: Macgregor Aubertin-Young <108430771+mauberti-bc@users.noreply.github.com>

BugFix: Method Attributes SQL (#1462)

- fix sql

Added DualAutocompleteUnitField.tsx to help reduce the size of the DualAutocompleteField.tsx.
Renamed some of the dual autocomplete field props, just to make them more consistent/predictable.
Fixed missing props in create/edit technique vantages (missing category data type prop).
Add formik snackbar error component to observation form.
Addressed a few react missing dependency warnings.

Update missed jsdoc comments.

Update missed jsdoc comments 2.

WIP: Add create observation sampling fields.

Working sampling fields.

Enhancements to sampling fields
@NickPhura NickPhura removed the Do Not Merge PR should not be merged label Mar 14, 2025
@NickPhura NickPhura added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Mar 19, 2025
@mauberti-bc
Copy link
Collaborator Author

Looks great! Some additions:

  • Include observation ID column in the manage observations table to show which subcounts are related
  • Sign should default to direct sighting (just as a convenience since this is the most common value)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
17.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@MacDeluca MacDeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create and edit seem to be working correctly!

@NickPhura NickPhura merged commit 2c6591a into dev Mar 24, 2025
19 of 23 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-647b branch March 24, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants