31775 Changes to support NIGS #673

severinbeauvais · 2026-01-30T19:22:36Z

Description of changes:

app version = 4.15.0
added CSS overirdes for disabled buttons
added disabled computeds / props to various components
added Components enum
added disabledComponents to store + getter + action
added goodStanding to business interface
added isGoodStanding getter
added message box to alteration filing
disabled components conditionally in alteration filing
misc cleanup

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

- imported latest shared share-structure component - added CSS overirdes for disabled buttons - added disabled computeds / props to various components - added Components enum - added disabledComponents to store + getter + action - added goodStanding to business interface + state init - added isGoodStanding getter - added message box to alteration filing - disabled components conditionally in alteration filing - misc cleanup

severinbeauvais · 2026-01-30T21:32:41Z

src/assets/styles/overrides.scss

+.theme--light.v-btn.v-btn--disabled.v-size--default .v-icon {
+  color: $app-blue !important;
+  opacity: 0.4;
+}


This potentially affects all buttons in this app, so I tested thoroughly...

Example text buttons:

Example large buttons (not affected):

Another example:

More examples:

Enabled:

Disabled (looks same as in Dev):

severinbeauvais · 2026-01-30T21:35:49Z

src/components/Alteration/Articles/Articles.vue

    >
      <CompanyProvisions
        :provisionsRemoved="areProvisionsRemoved"
+        :disabled="disabled"


"Articles" is a top-level component (used in Alteration view). It passes this prop down to its sub-components.

Articles is also used by CorpCorrections but in that case, disabled is False by default.

severinbeauvais · 2026-01-30T21:37:14Z

src/components/common/ShareStructure/ShareStructures.vue

+  /** Whether this component should be disabled. */
+  get disabled (): boolean {
+    return (this.getDisabledComponents.includes(Components.SHARE_STRUCTURES))
+  }


As with Articles, this is a top-level component and passes this property down to its sub-component.

severinbeauvais · 2026-01-30T21:38:53Z

src/enums/components.ts

+  ENTITY_NAME,
+  NAME_TRANSLATION,
+  SHARE_STRUCTURES
+}


I only implemented this for the alteration top-level components, minus BusinessContactInfo and FolioInformation. (RecognitionDateTime and OfficeAddresses are read-only.)

Ref:

Example (regular user):

severinbeauvais · 2026-01-30T22:19:52Z

src/views/Alteration.vue

+              Some actions on this page are unavailable because this company is not in good standing. Bring the
+              business back into good standing to access all actions.
+            </article>
+          </MessageBox>


severinbeauvais · 2026-01-30T22:29:00Z

src/components/Alteration/Articles/Articles.vue

severinbeauvais · 2026-01-30T23:14:35Z

src/components/Alteration/Articles/CompanyProvisions.vue

-    color: white !important;
-    background-color: $app-blue !important;
-    opacity: 0.2;
-  }


Not needed -- the Change button look fine with the global CSS overrides and the other buttons are never disabled.

severinbeauvais · 2026-01-30T23:16:36Z

src/components/common/YourCompany/NameTranslations/NameTranslation.vue

-      color: $app-blue !important;
-      opacity: 0.4;
-    }
-  }


Not needed -- the Change button look fine with the global CSS overrides and the other buttons are never disabled or only disabled when the component is expanded (which is blocked).

- added unit tests

severinbeauvais · 2026-01-30T23:20:39Z

/gcbrun

bcregistry-sre · 2026-01-30T23:24:04Z

Temporary Url for review: https://business-edit-dev--pr-673-9xq7u4ii.web.app

SB says, try this alteration while NIGS (login as BCREG0020):
https://business-edit-dev--pr-673-9xq7u4ii.web.app/BC0888459/alteration?accountid=2288&businessid=BC0888459
https://dev.edit.business.bcregistry.gov.bc.ca/BC0888459/alteration?accountid=2288&businessid=BC0888459

SB says, try this alteration while in good standing:
https://business-edit-dev--pr-673-9xq7u4ii.web.app/BC0888456/alteration?accountid=2288&businessid=BC0888456
https://dev.edit.business.bcregistry.gov.bc.ca/BC0888456/alteration?accountid=2288&businessid=BC0888456

Try this correction (login as staff) - should be unaffected:
https://business-edit-dev--pr-673-9xq7u4ii.web.app/BC0888459/correction/?accountid=3040&businessid=BC0888459&correction-id=259401
https://dev.edit.business.bcregistry.gov.bc.ca/BC0888459/correction/?accountid=3040&businessid=BC0888459&correction-id=259401

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

severinbeauvais · 2026-02-02T19:43:22Z

src/components/Alteration/Articles/CompanyProvisions.vue

                  small
                  color="primary"
                  class="more-actions-btn"
-                  :disabled="disabled"


This isn't needed because user can't get here (they cannot click Change button, which would then display this drop-down menu).

severinbeauvais · 2026-02-02T19:44:18Z

tests/unit/state-getters.spec.ts

      businessInfo: {
        legalName: 'MyLegalName',
-        legalType: 'BEN',
-        naicsCode: '100000'


NAICS only applies to firms.

severinbeauvais · 2026-02-02T20:15:56Z

package.json

    "@bcrs-shared-components/nature-of-business": "1.2.4",
    "@bcrs-shared-components/relationships-panel": "1.0.14",
-    "@bcrs-shared-components/share-structure": "2.2.48",
+    "@bcrs-shared-components/share-structure": "2.2.53",


Ref: bcgov/bcrs-shared-components#299

severinbeauvais · 2026-02-02T20:19:11Z

src/components/Alteration/Articles/Articles.vue

        :addedDates="getNewResolutionDates"
        :originalResolutions="getOriginalResolutions"
        :isEditMode="true"
+        :disabled="disabled"


ResolutionDates is only used by Alteration.

severinbeauvais · 2026-02-02T20:21:34Z

src/components/common/index.ts

 export { default as EntityInfo } from './EntityInfo.vue'
 export { default as ErrorContact } from './ErrorContact.vue'
 export { default as HelpSection } from './HelpSection.vue'
+export { default as MessageBox } from './MessageBox.vue'


So it can be imported like this:

severinbeauvais · 2026-02-02T20:30:37Z

src/store/store.ts

+
+    /** True if business is in good standing. */
+    isGoodStanding (): boolean {
+      return !!this.stateModel.businessInformation.goodStanding


Using !! just in case this prop isn't returned by API.

severinbeauvais · 2026-02-03T18:48:22Z

/gcbrun

bcregistry-sre · 2026-02-03T18:51:45Z

Temporary Url for review: https://business-edit-dev--pr-673-9xq7u4ii.web.app

loneil · 2026-02-03T20:27:50Z

@severinbeauvais I bet this is unrelated to this PR, but just curious for the steps

"""
Try this correction (login as staff) - should be unaffected:
https://business-edit-dev--pr-673-9xq7u4ii.web.app/BC0888459/correction/?accountid=3040&businessid=BC0888459&correction-id=259401
https://dev.edit.business.bcregistry.gov.bc.ca/BC0888459/correction/?accountid=3040&businessid=BC0888459&correction-id=259401
"""

I hit that link (either one) after logging in with my IDIR.

I get

But then if I hit Return to dashboard I get an ask to save?

loneil

Looks good to me I think

question about unrelated (I think...) other error just to confirm though

severinbeauvais · 2026-02-03T20:44:41Z

I get

I think that's because we were both using the same business and I delete the draft correction filing.

severinbeauvais self-assigned this Jan 30, 2026

Copilot AI review requested due to automatic review settings January 30, 2026 19:22

Copilot started reviewing on behalf of severinbeauvais January 30, 2026 19:22 View session

This comment was marked as outdated.

Sign in to view

severinbeauvais force-pushed the 31775 branch from 2b71b07 to ed4ae4b Compare January 30, 2026 21:06

severinbeauvais force-pushed the 31775 branch from ed4ae4b to a0fede3 Compare January 30, 2026 21:29

severinbeauvais requested a review from Copilot January 30, 2026 21:31

Copilot started reviewing on behalf of severinbeauvais January 30, 2026 21:32 View session

severinbeauvais commented Jan 30, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

severinbeauvais commented Jan 30, 2026

View reviewed changes

src/components/Alteration/Articles/Articles.vue

Copy link

Collaborator Author

severinbeauvais Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eg,

severinbeauvais commented Jan 30, 2026

View reviewed changes

- more cleanup

e261794

- added unit tests

severinbeauvais force-pushed the 31775 branch from 3740bdc to e261794 Compare January 30, 2026 23:18

severinbeauvais requested a review from Copilot January 30, 2026 23:33

Copilot started reviewing on behalf of severinbeauvais January 30, 2026 23:34 View session

severinbeauvais requested review from Rajandeep98, ketaki-deodhar, loneil, meawong and vysakh-menon-aot January 30, 2026 23:34

Copilot AI reviewed Jan 30, 2026

View reviewed changes

severinbeauvais commented Feb 2, 2026

View reviewed changes

wip

7abc13a

severinbeauvais commented Feb 2, 2026

View reviewed changes

loneil approved these changes Feb 3, 2026

View reviewed changes

severinbeauvais merged commit 1ad5e08 into bcgov:main Feb 3, 2026
14 of 15 checks passed

31775 Changes to support NIGS #673

31775 Changes to support NIGS #673

Uh oh!

Conversation

severinbeauvais commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

severinbeauvais Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais commented Jan 30, 2026

Uh oh!

bcregistry-sre commented Jan 30, 2026 • edited by severinbeauvais Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

severinbeauvais Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

severinbeauvais Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

severinbeauvais commented Feb 3, 2026

Uh oh!

bcregistry-sre commented Feb 3, 2026

severinbeauvais commented Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

severinbeauvais Jan 30, 2026 •

edited

Loading

bcregistry-sre commented Jan 30, 2026 •

edited by severinbeauvais

Loading

severinbeauvais Feb 2, 2026 •

edited

Loading