32321 - change_of_liquidators filing processor - fix missing offices#4047
Merged
deetz99 merged 1 commit intobcgov:mainfrom Feb 4, 2026
Merged
Conversation
deetz99
requested review from
argush3,
kialj876,
thorwolpert and
vysakh-menon-aot
vysakh-menon-aot
approved these changes
Feb 4, 2026
argush3
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32321
update_or_create_offices expects a dict for the
offices.update_or_create_offices(business: Business, offices: dict[str, dict[str, dict[str, str]]])During a changeAddressLiquidator, the user may only change a party address and not the liquidationRecordsOffice, in this case there would be no
officessubmitted in the filing payload.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).