Skip to content

32251 Updated banner styling #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
severinbeauvais merged 2 commits into from
Jan 29, 2026
Merged

32251 Updated banner styling #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de68015
- app version = 5.8.9
Jan 29, 2026
38a7e2e
- changed span to div
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.8.8",
"version": "5.8.9",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
43 changes: 30 additions & 13 deletions app/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,24 @@
<!-- Alert banner -->
<v-alert
v-if="bannerText"
id="alert-banner"
class="pa-0 ma-0"
tile
dense
type="warning"
class="mb-0 text-center colour-dk-text"
v-html="bannerText"
/>
>
<div class="container d-flex align-center py-3">
<v-icon
class="colour-dk-text"
size="28px"
>
mdi-information
</v-icon>

<div
class="colour-dk-text dark-gray-links font-size-14 pl-2"
v-html="bannerText"
/>
</div>
</v-alert>

<!-- Breadcrumb -->
<Breadcrumb
Expand Down Expand Up @@ -391,6 +403,19 @@ export default class App extends Mixins(
}
}

#alert-banner {
Copy link
Collaborator

@hfekete hfekete Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this be a class over depending on ID for any new styles. Can we do that ?

ID has higher specificity and and when overriding styles with IDs we need to use !important. If we are overriding classes, then it works as you would expect, last class applied wins.

Copy link
Collaborator Author

@severinbeauvais severinbeauvais Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built-in styles are pretty specific for alerts so I would have needed to concatenate several classes to target this exact component (and use !important).

So I used id instead of class to not risk setting styles for other alert components. Only this component needs these styles.

Copy link
Collaborator

@hfekete hfekete Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I wont argue against it this time, but lets have it for the future. As this will compound the need for !important. And now we will need specifically all the styles to target this ID with !important to be able to override e.g. the color of dark-gray-links inside alert.

Thanks

background-color: $BCgovGold5;
border-color: $BCgovGold5;

.container {
max-width: 1360px; // should match auth-web, etc
}

.dark-gray-links a {
color: $gray9 !important;
}
}

.namerequest-sbc-breadcrumb {
.v-btn {
width: 28px;
Expand Down Expand Up @@ -422,12 +447,4 @@ export default class App extends Mixins(
padding-left: 1rem;
}
}

#main-column .v-alert__wrapper {
color: $dk-text;
i {
color: $dk-text;
}
}

</style>
Loading