Skip to content

32111 - MHR API & UI: Update staff serial number search#2286

Merged
chenhongjing merged 2 commits intobcgov:mainfrom
chenhongjing:32111
Jan 30, 2026
Merged

32111 - MHR API & UI: Update staff serial number search#2286
chenhongjing merged 2 commits intobcgov:mainfrom
chenhongjing:32111

Conversation

@chenhongjing
Copy link
Collaborator

@chenhongjing chenhongjing commented Jan 30, 2026

Issue #: /bcgov/entity#32111

Description of changes:
API

  • Update staff serial number search algorithm:
    • Perform full serial number match first
    • Fallback to wildcard search only when no full match is found
    • Prioritize serial number exact match (also applies to QS)
  • Update unit tests
  • mhr-api=2.1.8

UI

  • Update search result not found wording from "Nil Result" to "No Result"
  • ppr-ui=6.0.5 (potential version conflict with Eve's work)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
@chenhongjing chenhongjing self-assigned this Jan 30, 2026
@chenhongjing
Copy link
Collaborator Author

/gcbrun

@chenhongjing
Copy link
Collaborator Author

Local testing

Staff

1. Full match exists
image

2. Full match doesn't exist, do wildcard search
image

3. No result
image

QS

1. Same as staff's full match
image

@chenhongjing chenhongjing marked this pull request as ready for review January 30, 2026 20:16
Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chenhongjing chenhongjing merged commit 8b3fdbd into bcgov:main Jan 30, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants