feat(components/data-manager): add foundational state management services#3
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat(components/data-manager): add foundational state management services#3devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…ices Create three new state management service classes in the data-manager library: - BaseStateService: Abstract base class providing common functionality for state management services including subscription cleanup and helper methods for creating BehaviorSubject and ReplaySubject instances - GridStateService: Service for managing grid-specific state (items, selected IDs, loading state) using private BehaviorSubject properties with public observable getters - StateDispatcherService: Generic service for handling state updates with built-in timestamp ordering, eliminating the need for manual scan operators These services establish a new state management pattern modeled after the existing SkyDataManagerService, using private BehaviorSubject properties with public observable getters for direct property subscriptions. Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Phase 1 of the state management pattern refactoring by creating three foundational service classes in
libs/components/data-manager/src/lib/state/:ngUnsubscribeSubject and helper methods for creating BehaviorSubject/ReplaySubject instancesThe pattern follows the existing
SkyDataManagerServiceapproach of using private#class fields for BehaviorSubjects with public observable getters.Review & Testing Checklist for Human
public-api.ts- confirm if this is intentional for Phase 1 or if exports should be addedtimestampfield is captured but not used for ordering - verify this matches the intended design (the task description mentions "built-in timestamp ordering")createBehaviorSubjectandcreateReplaySubjectare defined butGridStateServicecreates BehaviorSubjects directly - confirm if this is the intended patternNotes
Link to Devin run: https://app.devin.ai/sessions/dd372539e12549b4a7601e70f2f9e4a9
Requested by: @bcmake