build(dev-infra): migrate Nx from 21.5.2 to 22.3.3#4
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
build(dev-infra): migrate Nx from 21.5.2 to 22.3.3#4devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
This commit migrates the SKY UX monorepo from Nx 21.5.2 to Nx 22.3.3. Key changes: - Update all @nx/* packages from 21.5.2 to 22.3.3 - Update Angular packages from 20.x to 21.x - Update Storybook from 9.x to 10.x - Update Jest from 29.x to 30.x - Update Cypress from 14.x to 15.x - Update Vitest from 3.x to 4.x - Update zone.js from 0.15.1 to 0.16.0 - Fix decorate-angular-cli.js for Nx 22 compatibility (removed deprecated decorateCli call) - Update TypeScript configurations with module: preserve and moduleResolution: bundler - Update jest-preset-angular setup to use setupZoneTestEnv function - Update e2e-schematics package.json peer dependencies - Add AI migration instructions for Storybook 10 and Vitest 4 Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build(dev-infra): migrate Nx from 21.5.2 to 22.3.3
Summary
This PR migrates the SKY UX monorepo from Nx 21.5.2 to Nx 22.3.3, along with associated dependency upgrades. This is Phase 1 of the migration focusing on core infrastructure.
Key dependency updates:
Infrastructure changes:
module: "preserve"andmoduleResolution: "bundler"(Angular 21 requirement)import 'jest-preset-angular/setup-jest'tosetupZoneTestEnv()functiondecorate-angular-cli.jsby removing deprecateddecorateCli()calltools/ai-migrations/Review & Testing Checklist for Human
This is a high-risk PR due to multiple major version upgrades. Please verify:
nx serve playground,nx build, andnx teston a few projectstools/ai-migrations/MIGRATE_STORYBOOK_10.md)decorate-angular-cli.jschange removed the deprecateddecorateCli()call; verifyng build,ng teststill invoke Nx properlyRecommended test plan:
npm cinx graphto verify project graph is intactnx build playgroundandnx test coreto verify basic functionalitynx run storybook:build-storybookto verify Storybook worksNotes
migrations.jsonfile was deleted after migrations completedLink to Devin run: https://app.devin.ai/sessions/3dfdc0def01943b79abd8cbda82a4f78
Requested by: @bcmake