feat(list-builder-view-grids): implement Phase 1 and Phase 2 of state management refactoring#5
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
… management refactoring Phase 1: Create New State Architecture Foundation - NewGridState: Uses individual BehaviorSubjects for displayedColumns and columns - NewGridStateDispatcher: Handles actions and updates individual state properties Phase 2: Create New Component Implementation - NewSkyListViewGridComponent: Uses new state pattern without scan operators - NewSkyListColumnSelectorActionComponent: Uses combineLatest for multiple observables The new implementation eliminates timing issues where state updates were consumed out of order by using a 'static state object with observable properties' pattern instead of the previous 'state object observable with static properties' pattern. Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(list-builder-view-grids): implement state management refactoring Phase 1 & 2
Summary
This PR implements Phase 1 and Phase 2 of the state management refactoring for the list-builder-view-grids component. The refactoring addresses technical debt documented around lines 593-598 of
list-view-grid.component.ts, wherescanoperators were used as workarounds for timing issues caused by the "state object observable with static properties" pattern.Phase 1 - New State Architecture:
NewGridState: Uses individualBehaviorSubjectinstances fordisplayedColumnsandcolumnsproperties, exposing them as separate observablesNewGridStateDispatcher: Handles actions and updates individual state properties through update methodsPhase 2 - New Component Implementation:
NewSkyListViewGridComponent: Uses the new state pattern with simplifiedgetGridItems()andgetSelectedIds()methods that don't requirescanoperatorsNewSkyListColumnSelectorActionComponent: UsescombineLatestto subscribe to multiple observables from the new state patternAll new components are created alongside existing deprecated components (prefixed with "New") for parallel deployment.
Review & Testing Checklist for Human
openColumnSelector()works correctly with the newcombineLatestpattern - ensure both columns and displayedColumns are retrieved atomically.scanoperators fromgetGridItems()andgetSelectedIds()doesn't introduce new race conditions.Recommended test plan:
sky-new-list-view-gridwith multiple columnsNotes
@internalfor the parallel deployment phaseSkyLogServicedeprecation logging was intentionally omitted from the new componentLink to Devin run: https://app.devin.ai/sessions/424126bd0147451dadd1c68fba8fdcef
Requested by: @bcmake