feat(list-builder-view-grids): add new state architecture (Phase 1 & 2)#6
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
feat(list-builder-view-grids): add new state architecture (Phase 1 & 2)#6devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
…(Phase 1) - Add NewGridState class with BehaviorSubject observables for columns and displayedColumns - Add NewGridStateDispatcher class for direct state updates without action/orchestrator pattern - Export new classes from public API This implements the foundation for refactoring from 'state object observable with static properties' to 'static state object with observable properties' pattern, eliminating timing issues that required scan operator workarounds. Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…hitecture (Phase 2) - Add NewSkyListViewGridComponent that removes scan operator workarounds - Add NewSkyListColumnSelectorActionComponent using combineLatest with individual observables - Update modules to declare and export new components - Export new components from public API The new components use direct subscriptions to BehaviorSubject observables from Phase 1, eliminating timing issues without needing scan operator workarounds. Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(list-builder-view-grids): add new state architecture (Phase 1 & 2)
Summary
This PR implements Phase 1 and Phase 2 of the state management refactoring for the list-builder-view-grids component. It introduces a new state architecture using BehaviorSubjects to expose individual observables, eliminating timing issues that currently require
scanoperator workarounds.Phase 1 - State Foundation:
NewGridState- State class with BehaviorSubjects forcolumnsanddisplayedColumns, exposing both full AsyncList observables and convenience item array observablesNewGridStateDispatcher- Dispatcher with direct methods (loadColumns,loadDisplayedColumns,updateColumn,updateDisplayedColumn) replacing the action/orchestrator patternPhase 2 - New Components:
NewSkyListViewGridComponent(624 lines) - Refactored grid component that removesscanoperator workarounds ingetGridItems(),getSelectedIds(), andonViewActive()methodsNewSkyListColumnSelectorActionComponent(195 lines) - Column selector usingcombineLatestwith individual observables instead of subscribing to entire state objectAll classes are exported from the public API and modules are updated to declare/export the new components.
Review & Testing Checklist for Human
scanoperators but should maintain the same functionality. Test with actual data to confirm timing issues are resolved.AsyncListconstructor parameter order matches the class definition:(items, lastUpdate, loading, count)- seenew-grid-state-dispatcher.tslines 34-39, 56-63@skyux/list-builder-view-gridsmodule is deprecated)updateColumn/updateDisplayedColumncould cause issues withSkyGridColumnModelobjects that have methods or gettersTest plan:
npm run lint:affectedto verify lint passes (already done)NewSkyListViewGridComponentwith sample datascanoperatorsSkyListViewGridComponentto ensure parityNotes
@internalbut exported for use within the librarysky-new-list-view-gridandsky-new-list-column-selector-actionLink to Devin run: https://app.devin.ai/sessions/f149bdc8b43449f095ba57c71390edf5
Requested by: @bcmake