feat(components/grids): add test harness for grid component#9
Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Open
feat(components/grids): add test harness for grid component#9devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
Add comprehensive test harness for @skyux/grids component including: - SkyGridHarness for testing grid component - SkyGridColumnHarness for testing grid columns - SkyGridRowHarness for testing grid rows - Filter interfaces for all harnesses - Public API exports - Path mapping in tsconfig.base.json - Comprehensive test coverage Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…tting - Add @angular/cdk as peer dependency for test harness CDK imports - Fix code formatting with Prettier Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
…iguration Co-Authored-By: benc@cognition.ai <Benc@windsurf.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(components/grids): add test harness for grid component
Summary
Adds a comprehensive test harness for the
@skyux/gridscomponent, which was identified as a high-priority component lacking test harness support. The implementation follows established patterns from existing harnesses in the codebase (forms, indicators, lists).The harness includes:
SkyComponentHarnesswith methods for columns, rows, multiselect, highlighting, fit mode, and toolbar detection@skyux/grids/testingUpdates since last revision
@angular/cdkas a peer dependency (required for CDK testing utilities used by the harness)project.jsonwith testing module configuration vianpm run dev:update-library-dependenciesReview & Testing Checklist for Human
sky-cmp-id,sky-grid-multiselect-selected-row,aria-current="true",sky-grid-fit,sky-grid-has-toolbar. Confirm these match the actual grid component implementation.select()/deselect()methods click the row element. Verify this correctly toggles selection.@skyux/forms/testingor@skyux/indicators/testingfor consistency.Recommended test plan:
@skyux/grids/testingin a consuming application and verify the harness works with actual grid componentsNotes
Link to Devin run: https://app.devin.ai/sessions/5e91bb36192347c9a2f94810f9a61f09
Requested by: @bcmake