Skip to content

Represent MARITIME_TRADE as 10-int list#289

Open
zarns wants to merge 2 commits intobcollazo:masterfrom
zarns:maritime
Open

Represent MARITIME_TRADE as 10-int list#289
zarns wants to merge 2 commits intobcollazo:masterfrom
zarns:maritime

Conversation

@zarns
Copy link
Copy Markdown
Contributor

@zarns zarns commented Nov 3, 2024

closes #157

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 3, 2024

‼️ Deploy request for catanatron-staging rejected.

Name Link
🔨 Latest commit a7ec879

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 3, 2024

Pull Request Test Coverage Report for Build 11647641862

Details

  • 20 of 21 (95.24%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 95.969%

Changes Missing Coverage Covered Lines Changed/Added Lines %
catanatron_core/catanatron/state.py 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
catanatron_core/catanatron/state.py 1 97.16%
Totals Coverage Status
Change from base Build 10864300657: -0.003%
Covered Lines: 1381
Relevant Lines: 1439

💛 - Coveralls

@bcollazo
Copy link
Copy Markdown
Owner

Hey @zarns Thanks for taking a stab at this! Could you share performance numbers before and after this change? The motivation for this is to allow for faster games / more games per second. I wonder what's the improvement of this.

It might also be interesting to show how does games that involve bots that do a lot of copying (.copy) are affected by this change. For example games with the MCTS bot.

Thanks again!

@zarns
Copy link
Copy Markdown
Contributor Author

zarns commented Nov 12, 2024

Looks like these changes make the games slightly faster on average with AlphaBetaPlayer/MCTSPlayer/RandomPlayer

  • catanatron-play -n 1000
    • before: 43.4 sec
    • after: 42.5 sec
  • catanatron-play --players=AB,R,W --num=100
    • before: 309.36 sec
    • after: 285.75 sec
  • catanatron-play --players=AB,M --num=10
    • before: 62.27 sec
    • after: 66.8 sec (slightly slower?)
  • catanatron-play --players=AB,M,R --num=20
    • before: 224.7 sec
    • after: 206.9 sec (slightly faster on average)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] Make MARITIME_TRADE action's value a 10-integer list

3 participants