Refactor: Rename adjacent_tiles to node_to_tiles#321
Open
EphraiemSarabamoun wants to merge 2 commits intobcollazo:masterfrom
Open
Refactor: Rename adjacent_tiles to node_to_tiles#321EphraiemSarabamoun wants to merge 2 commits intobcollazo:masterfrom
EphraiemSarabamoun wants to merge 2 commits intobcollazo:masterfrom
Conversation
This commit renames the 'adjacent_tiles' attribute in the CatanMap class to 'node_to_tiles' for better clarity, as suggested by a TODO comment. All usages across the codebase have been updated to reflect this change.
✅ Deploy Preview for catanatron-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Pull Request Test Coverage Report for Build 16064219491Details
💛 - Coveralls |
bcollazo
reviewed
Jul 2, 2025
Owner
bcollazo
left a comment
bcollazo
left a comment
There was a problem hiding this comment.
Boom! Thanks for this!
I think there are still some additional usages that I see. I think the Frontend might expect the old naming. Could you change these as well and ensure the Frontend still works well (by running the docker compose locally end-to-end)? Thanks!
pachewise
reviewed
Jul 2, 2025
| "adjacent_tiles": obj.state.board.map.adjacent_tiles, | ||
| "map": { | ||
| "node_to_tiles": obj.state.board.map.node_to_tiles, | ||
| "node_production": obj.state.board.map.node_production, |
Contributor
There was a problem hiding this comment.
do we need node_production here? (cc: @bcollazo)
This commit resolves the feedback on the previous change: - Renames all remaining instances of to in the tests and UI codebase for consistency. - Removes the unused field from the JSON payload. - Adjusts the UI's to be compatible with the local development environment. - Fixes a frontend crash by restructuring the game state JSON to match the frontend's expectations. is now a top-level property.
Author
|
Hey guys, tried to fix the terminology in the frontend and checked the UI to make sure it's working. Please let me know if anything else needs to be changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames the 'adjacent_tiles' attribute in the CatanMap class to 'node_to_tiles' for better clarity, as suggested by a TODO comment. All usages across the codebase have been updated to reflect this change.