Skip to content

Have Spiral Pips start anywhere in outer ring#370

Open
samyaksingh2004 wants to merge 3 commits intobcollazo:mainfrom
samyaksingh2004:fix-spiral
Open

Have Spiral Pips start anywhere in outer ring#370
samyaksingh2004 wants to merge 3 commits intobcollazo:mainfrom
samyaksingh2004:fix-spiral

Conversation

@samyaksingh2004
Copy link
Copy Markdown

Was playing around with the catanatron env when I faced the same issue. Looked at the original draft PR for this issue: #364 and added some changes and tests to check the proper functionality.

Summary

  • Allow official_spiral number placement to start at any random outer corner.
  • Filter outer ring coordinates mathematically to guarantee starting on a valid corner.

Testing

  • python -m pytest tests/models/ -q
  • Added regression test test_spiral_starts_at_random_corners to verify multiple unique corner starts.
  • Ran local UI visualizer to ensure red number isolation remains intact.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 26, 2026

👷 Deploy request for catanatron-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 569aa34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant