Have Spiral Pips start anywhere in outer ring#370
Open
samyaksingh2004 wants to merge 3 commits intobcollazo:mainfrom
Open
Have Spiral Pips start anywhere in outer ring#370samyaksingh2004 wants to merge 3 commits intobcollazo:mainfrom
samyaksingh2004 wants to merge 3 commits intobcollazo:mainfrom
Conversation
👷 Deploy request for catanatron-staging pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was playing around with the catanatron env when I faced the same issue. Looked at the original draft PR for this issue: #364 and added some changes and tests to check the proper functionality.
Summary
official_spiralnumber placement to start at any random outer corner.Testing
python -m pytest tests/models/ -qtest_spiral_starts_at_random_cornersto verify multiple unique corner starts.