Add support for ability-based damage bonus mechanic#226
Open
Add support for ability-based damage bonus mechanic#226
Conversation
Adds ExtraDamageIfOpponentActiveHasAbility mechanic for the effect "If your opponent's Active Pokémon has an Ability, this attack does 40 more damage." Covers A3 123, A3 175, A4b 260, A4b 261. https://claude.ai/code/session_01D9WZtbdn3onfUqkzmGS4H1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement support for attack mechanics that deal extra damage when the opponent's Active Pokémon has an Ability.
Key Changes
ExtraDamageIfOpponentActiveHasAbilityvariant to theMechanicenum with configurableextra_damageparameterextra_damage_if_opponent_active_has_ability()function that:forecast_effect_attack_by_mechanic()to process this mechanic during attack resolutionImplementation Details
The implementation follows the existing pattern used for similar conditional damage mechanics (e.g.,
ExtraDamageIfOpponentHpMoreThanSelf). The ability check uses the card'sget_ability()method to determine if an Ability is present on the opponent's Active Pokémon.https://claude.ai/code/session_01D9WZtbdn3onfUqkzmGS4H1