Skip to content

Conversation

@bczernecki
Copy link
Owner

Bug fixes for minor problems found during downloading dataset with meteo_imgw_() family of functions + simultanously testing new feature for selectively downloading smaller amount of data if SYNOP dataset is requested

@bczernecki bczernecki requested a review from Copilot January 21, 2026 00:24
@bczernecki bczernecki self-assigned this Jan 21, 2026
@bczernecki bczernecki added bug Something isn't working enhancement New feature or request labels Jan 21, 2026
@bczernecki bczernecki linked an issue Jan 21, 2026 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces selective downloading for the meteo_imgw_daily function when requesting SYNOP station data, allowing users to download data for specific stations instead of all available stations. The changes also include bug fixes for handling station names with extra whitespace.

Changes:

  • Added selective download feature for SYNOP stations by matching station names to WMO IDs
  • Fixed station name handling by trimming whitespace from station names throughout the data processing
  • Updated station filtering logic to properly handle multiple station names using unique() and unlist()

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
R/meteo_imgw_daily.R Added selective download logic for SYNOP stations, trimws() calls for station names, and improved station filtering
man/meteo_imgw_daily.Rd Updated documentation to clarify station parameter accepts vectors and explain handling of renamed stations
NEWS.md Added version 1.2.6 changelog documenting the selective download feature and whitespace fix
DESCRIPTION Bumped package version from 1.2.5 to 1.2.6

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 90.71618% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.99%. Comparing base (4001281) to head (c8e8a7e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
R/meteo_imgw_hourly.R 83.80% 17 Missing ⚠️
R/meteo_imgw_monthly.R 90.47% 10 Missing ⚠️
R/meteo_imgw_daily.R 95.62% 6 Missing ⚠️
R/hydro_imgw_daily.R 91.66% 1 Missing ⚠️
R/match_imgw_wmoid_inds.R 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   87.25%   92.99%   +5.73%     
==========================================
  Files          32       33       +1     
  Lines        1781     1884     +103     
==========================================
+ Hits         1554     1752     +198     
+ Misses        227      132      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bczernecki bczernecki merged commit 9491d60 into master Jan 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

meteo_imgw speed up for a single station

2 participants