-
Notifications
You must be signed in to change notification settings - Fork 26
feat: selective download for meteo_imgw_daily #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: selective download for meteo_imgw_daily #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces selective downloading for the meteo_imgw_daily function when requesting SYNOP station data, allowing users to download data for specific stations instead of all available stations. The changes also include bug fixes for handling station names with extra whitespace.
Changes:
- Added selective download feature for SYNOP stations by matching station names to WMO IDs
- Fixed station name handling by trimming whitespace from station names throughout the data processing
- Updated station filtering logic to properly handle multiple station names using
unique()andunlist()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| R/meteo_imgw_daily.R | Added selective download logic for SYNOP stations, trimws() calls for station names, and improved station filtering |
| man/meteo_imgw_daily.Rd | Updated documentation to clarify station parameter accepts vectors and explain handling of renamed stations |
| NEWS.md | Added version 1.2.6 changelog documenting the selective download feature and whitespace fix |
| DESCRIPTION | Bumped package version from 1.2.5 to 1.2.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 87.25% 92.99% +5.73%
==========================================
Files 32 33 +1
Lines 1781 1884 +103
==========================================
+ Hits 1554 1752 +198
+ Misses 227 132 -95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bug fixes for minor problems found during downloading dataset with meteo_imgw_() family of functions + simultanously testing new feature for selectively downloading smaller amount of data if SYNOP dataset is requested