refactor(processor): optimize #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarcus
force-pushed
the
refactor/optimize-rust-pro
branch
from
967c065 to
38a60fc
Compare
Refactor the processor crate to improve performance and code quality. Key changes: - Optimize refs_to_string in render.rs by replacing map/collect/join chain with a single for loop and write!. This reduces intermediate string allocations significantly, improving memory efficiency for large bibliographies. - Introduce ProcessorError enum in error.rs using thiserror to provide strongly typed, descriptive errors instead of bare Strings. - Update Processor methods to return Result<..., ProcessorError> for better error propagation. - Clean up debug println! statements and improve comments throughout the crate. - Update lib.rs to export the new error module.
bdarcus
force-pushed
the
refactor/optimize-rust-pro
branch
from
38a60fc to
cc8ea27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, allocations and error handling.