Open
Conversation
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/tools/clients/gmail.go">
<violation number="1" location="pkg/tools/clients/gmail.go:498">
P2: Sanitize `In-Reply-To` and `References` before writing them into raw headers to prevent header injection via unexpected CR/LF characters.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary by cubic
Fixes Gmail threading by adding proper In-Reply-To and References headers on replies and drafts using Message-ID values from the target thread, and sanitizes reply headers to prevent injection. Emails still send if header fetch fails.
getThreadReplyHeadersto fetch Message-IDs from/threads/{id}and pass them tobuildRawEmail.createDraftandsendEmailto include reply headers whenthread_idis provided; graceful fallback on fetch errors.In-Reply-ToandReferencesinbuildRawEmail; added tests for header inclusion, 404 fallback, and injection sanitization inpkg/tools/clients.Written for commit 1e4a3d9. Summary will update on new commits.