Merged
Conversation
There was a problem hiding this comment.
2 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/views/copilot.go">
<violation number="1" location="pkg/views/copilot.go:599">
P2: Use the raw user message for vector retrieval context; passing the expanded prompt (with attached file text) can skew semantic search results.</violation>
</file>
<file name="pkg/views/resolver.go">
<violation number="1" location="pkg/views/resolver.go:1857">
P1: Negative `offset` is not clamped before slicing, which can panic on `rows[offset:end]`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary by cubic
Add real server-side pagination and free-text search for view rows, and return pagination metadata in responses. Also improves Copilot context selection, import speed, and mailbox coverage.
New Features
ResolveDataacceptsoffset,limit, andsearch(search applies before pagination) and returnsTotalwith paged rows.GetRowsPageandSearchRowsText; tool output now includestotal,offset, andreturned.Refactors
UpsertRowsNoEmbed), ensure vector index, and runEmbedRowsAsync; propagation uses parallel workers with a longer timeout.GetRowsForMailbox, increases email fetch limit to 500, and also queries outputs by the view’s agents for completeness;search_textis rebuilt in the background on cell edits.Written for commit eeeab06. Summary will update on new commits.