Open
Conversation
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/views/email_threads.go">
<violation number="1" location="pkg/views/email_threads.go:450">
P2: `receivedAt.UnixMilli()` returns `-62135596800000` when `ReceivedTime()` returns the zero `time.Time` (parse failure). Guard with a zero check so the behaviour matches the Gmail path, which defaults to `0`.</violation>
<violation number="2" location="pkg/views/email_threads.go:653">
P2: HTML tag matching is case-sensitive, so Outlook emails with uppercase tags (e.g., `<BR>`, `</P>`) lose line breaks. Lowercase the input before the tag-replacement pass, or use a case-insensitive approach such as `strings.EqualFold` / `regexp.MustCompile(`(?i)...`)`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary by cubic
Adds first-class support for both Gmail and Outlook mailboxes with provider-scoped thread fetching and de-duplication. Thread messages now include a millisecond Timestamp for consistent cross-provider sorting.
New Features
EmailThreadRef(ID + integration) with provider-qualified keys to prevent duplicates; messages includeTimestamp(ms) for stable ordering.sourceclients.OutlookClient.integrationin metadata/data; also infers from_tool,conversation_id/conversationId,thread_id/threadId, and URLs inemail_link/uriordeeplink.integration=all|gmail|outlook; filters outputs to the selected provider and aggregates threads from outputs and row cells (cellthread_ids are scoped by the selected provider).types.Teamsintegration metadata (read/write).Migration
integrationquery param to/api/v1/views/:view_id/mailbox(all,gmail, oroutlook); missing param returns 400.integrationin email outputs; otherwise it’s inferred from IDs/links.conversation_id/conversationId(or an Outlook link) for Outlook; usethread_id/threadId(or a Gmail link) for Gmail. Row cellthread_idcan remain comma-separated; the selectedintegrationdetermines which mailbox is used.Written for commit bb8effc. Summary will update on new commits.