Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add outbound networking controls for sandboxes (block all or CIDR allow list) and a runtime API to change permissions without restarting. Also update
listUrls()to return URLs keyed by port.New Features
blockNetworkandallowList(CIDR) to sandbox/stub config; they are mutually exclusive and validated. Config is sent asblock_networkandallow_listduring stub creation.SandboxInstance.updateNetworkPermissions(blockNetwork, allowList?)to update rules via/network/update; rejects conflicting inputs and throws on failure.listUrls()now returnsRecord<number, string>mapping ports to URLs.Migration
listUrls()to handle a map keyed by port instead of an array.blockNetwork=trueorallowList, not both.Written for commit 9ef69eb. Summary will update on new commits.