Fix node coordinates data type#614
Merged
isteinbrecher merged 2 commits intobeamme-py:mainfrom Mar 23, 2026
Merged
Conversation
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
davidrudlstorfer
approved these changes
Mar 23, 2026
Collaborator
davidrudlstorfer
left a comment
davidrudlstorfer
left a comment
There was a problem hiding this comment.
nice:) thanks for the nice unit test as well
There was a problem hiding this comment.
Pull request overview
This PR fixes a type-casting bug in beamme.core.node.Node by ensuring node coordinates are always stored as floating-point arrays, preventing in-place vector additions from failing when initialized with integer coordinates.
Changes:
- Force
Node.coordinatesto be created withdtype=floatduring initialization. - Add a parametrized test covering mixed input types (lists and NumPy arrays, int and float) and in-place coordinate increments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/beamme/core/node.py |
Ensures self.coordinates is always a float NumPy array to support += with float increments safely. |
tests/beamme/core/test_beamme_core_node.py |
Adds coverage to verify coordinates are handled correctly across multiple input/increment type combinations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isteinbrecher
temporarily deployed
to
cubit_secrets_trusted
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force node coordinates to be of floating type. This fixes the previously existing bug: