Skip to content

Conversation

@jokester
Copy link
Contributor

Hi I learned how to write my own importers by reading the code (btw it was intuitive).

These changes are by-products but I thought they may help others too.

@blais
Copy link
Member

blais commented Mar 18, 2025

Hmm, lots of failure, various reasons.

@jokester
Copy link
Contributor Author

I added a commit to fix errors I could understand. Can someone approve the CI run again?

@jokester
Copy link
Contributor Author

There was a lint error in code I didn't touch. Should this be fixed too?

https://github.com/beancount/beangulp/actions/runs/13861040615/job/38936900664

 beangulp/importers/config_test.py:24:31: C420 [*] Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
   |
23 |       def setUp(self):
24 |           self.default_config = {key: 'Assets:Something'
   |  _______________________________^
25 | |                                for key in SimpleTestImporter.REQUIRED_CONFIG}
   | |_____________________________________________________________________________^ C420
26 |
27 |       def test_constructors(self):
   |
   = help: Replace with `dict.fromkeys(iterable)`)

@jokester jokester force-pushed the add-type-annotations branch from c8cfc7f to 8ff91fb Compare March 23, 2025 15:31
@jokester
Copy link
Contributor Author

I think I fixed them all, please run again 🙏🏽

@blais
Copy link
Member

blais commented Mar 23, 2025

Thank you!

@blais blais merged commit 730002c into beancount:master Mar 23, 2025
19 checks passed
@jokester jokester deleted the add-type-annotations branch March 24, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants