Do not install "examples" or "tools" in site-packages #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blais
approved these changes
May 19, 2025
dnicolodi
requested changes
Jun 12, 2025
pyproject.toml
Outdated
| [tool.setuptools.packages] | ||
| find = {} | ||
| [tool.setuptools.packages.find] | ||
| exclude = ["examples*", "tools*"] |
Collaborator
There was a problem hiding this comment.
There are other top level directories that would need to be excluded. I would reverse this and use an include pattern instead.
dnicolodi
force-pushed
the
no-install-examples-tools
branch
from
57872b4 to
c65120f
Compare
dnicolodi
force-pushed
the
no-install-examples-tools
branch
from
c65120f to
d412dc5
Compare
dnicolodi
approved these changes
Jun 12, 2025
Collaborator
|
This was a big oversight when setting up the packaging. Thanks! |
Contributor
Author
You’re welcome. Trust me: this happens a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not install
examplesortoolsas top-level modules in site-packages.