Allow ingest() to exit normally rather than calling sys.exit(0). #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blais
reviewed
Jun 26, 2025
Makefile
Outdated
| test: | ||
| (env -u PYTHONPATH uv run --isolated --python 3.13 python -m pytest) | ||
| (env -u PYTHONPATH uv run --isolated --python 3.13 \ | ||
| sh -c "uv pip install petl pytest && python -m pytest") |
Member
There was a problem hiding this comment.
Don't do this; instead use uv run --with petl or somesuch.
Author
There was a problem hiding this comment.
Thanks! I wasn't previously aware of --with. That's so much cleaner.
Member
|
LGTM. Please make the one change I'm requesting (in both places). |
Collaborator
|
Also please stick to the conventional format for commit messages. |
By allowing kwargs, one can pass standalone_mode=False. That makes ingest() return normally rather than calling sys.exit(0). That provides a chance for further processing, for instance splitting the output into multiple files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing standalone_mode=True to Ingest.call() so it exits normally rather than calling sys.exit(0). That
allows further processing afterward. In my use case, after extracting the transactions from ofx/csv, I want to extract balances from pdfs for comparison, then split the output lines into multiple journal files.
I also tweaked the Makefile as it was complaining .../uv/builds-v0/.tmp88uxMu/bin/python: No module named pytest