Unify requests configuration #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
Yes, issue description for #101 matches my experience. |
|
This PR is more complete than mine. Please go ahead with this one if this passes the tests. |
Collaborator
|
Thanks @delmarrerikaine @rizaon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces fix for error with yahoo source that started recently.
The error reproduce
Run in console:
bean-price -d 2025-02-20 -e USD:yahoo/AAPLwhich fails with error, while the
bean-price -e USD:yahoo/AAPLworks successfully
Root cause
User-Agent behavior is different for
beanprice.sources.yahoo.get_latest_pricewhich works, andbeanprice.sources.yahoo.get_historical_priceThe changes
get_latest_price-like configuration.test_get_latest_priceunit testI have tried to provide minimal working solution in this PR, happy to adapt if more changes required.