Add Euronext price source #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasdenH
force-pushed
the
euronext
branch
2 times, most recently
from
52b234c to
620c2ed
Compare
Contributor
Author
|
Now CI should not fail on linting/typing/testing anymore due to the added/changed files. |
Contributor
|
@ThomasdenH I believe you can rerun checks and they will succeed now (after #93 was merged) |
Contributor
Author
|
Tests are still failing due to some typing in an unrelated file, but the PR should be ready now! |
Lintint
Contributor
Author
|
Rebased to latest master, CI is passing now. Let me know if anything should be improved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a price source from
euronext.com, which provides the ability to download prices as a.csvfile. It does not require an API key for this. This adds quite some tickers that just weren't available before.