Skip to content

Conversation

@d-perl
Copy link
Contributor

@d-perl d-perl commented Jul 22, 2025

closes #564

@d-perl d-perl force-pushed the fix/reading_separator branch from 11d30f8 to f5cc4bd Compare July 22, 2025 17:49
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@d-perl d-perl marked this pull request as ready for review July 23, 2025 12:41
@d-perl d-perl requested review from cappel89 and wakonig July 23, 2025 12:41
@d-perl
Copy link
Contributor Author

d-perl commented Jul 23, 2025

@wakonig what do you think of this? Doesn't look like it requires too many changes, but if we want to do it we should before anyone starts writing user scripts that access readings

@wakonig
Copy link
Contributor

wakonig commented Jul 23, 2025

I like it! - Let's postpone it to V4 though. I'm also preparing a few breaking changes atm

@d-perl
Copy link
Contributor Author

d-perl commented Jul 23, 2025

Sounds good, I'll try to keep it up to date. @cappel89 @wyzula-jan try to write things that use the device full_name to access readings rather than the hardcoded underscore if you remember?

@wakonig should we start a v4 release branch soon then?

@wakonig
Copy link
Contributor

wakonig commented Jul 23, 2025

@wakonig should we start a v4 release branch soon then?

Yes, if you want, you can already create a pre_release_v4 branch and we merge it

@d-perl d-perl force-pushed the fix/reading_separator branch from 769afe0 to b274185 Compare October 22, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use _child_name_separator = "-" for our ophyd devices

3 participants