Skip to content

Add session parameter to AsyncClient #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zakharych wants to merge 1 commit into from
Closed

Add session parameter to AsyncClient #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fhirpy/base/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,11 @@ def _build_request_url(self, path, params):

class AsyncClient(AbstractClient, ABC):
aiohttp_config = None
session: aiohttp.ClientSession = None

def __init__(self, url, authorization=None, extra_headers=None, aiohttp_config=None):
def __init__(self, url, authorization=None, extra_headers=None, aiohttp_config=None, session=None):
self.aiohttp_config = aiohttp_config or {}
self.session = session

super().__init__(url, authorization, extra_headers)

Expand All @@ -119,8 +121,10 @@ async def execute(self, path, method="post", **kwargs):
async def _do_request(self, method, path, data=None, params=None, returning_status=False):
headers = self._build_request_headers()
url = self._build_request_url(path, params)
async with aiohttp.ClientSession(headers=headers) as session:
async with session.request(method, url, json=data, **self.aiohttp_config) as r:
_session = self.session or aiohttp.ClientSession(headers=headers)
async with _session as session:
logging.error('session id %s', id(session))
async with session.request(method, url, json=data,headers = headers, **self.aiohttp_config) as r:
if 200 <= r.status < 300:
data = await r.text()
r_data = json.loads(data, object_hook=AttrDict) if data else None
Expand Down