Fix DNS resolution and improve progress bar functionality #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix tokio runtime conflicts in DNS resolver initialization - Improve address parsing to avoid unnecessary DNS resolution - Enhance progress bar reliability and visibility - Update dependencies (clap 4.5.41, tokio, etc.) - Add better error handling for network operations - Optimize CIDR network parsing performance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add CI workflow for automated testing and build verification - Add release workflow for cross-platform binary compilation - Support Windows, macOS (Intel/ARM), and Linux (x64/ARM64) - Automatic package creation with installation scripts - Checksums and GitHub Releases integration Platforms supported: - Windows x64 (MSVC) - macOS Intel x64 - macOS Apple Silicon (ARM64) - Linux x64 (GNU) - Linux ARM64 (GNU) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove needless else clause in build.rs hex parsing logic - Improves code quality and passes clippy linting checks 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace trim().split('\n') with lines() in build.rs
- Add backticks to BTreeMap in documentation
- Fix needless_pass_by_value and implicit_clone warnings
- Remove redundant continue in scanner loop
- Add comprehensive PR description
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
@wooluo, thanks for the PR. However, there's far too much contained in this single PR to be merged as-is. Looking firstly at the things you mention in the PR title, "Fix DNS Resolution" and "Improve Progress Bar Functionality":
Regarding changes unrelated to the PR's title:
Again, thanks for raising the PR but each issue you've addressed is better dealt with in isolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DNS Resolution and Improve Progress Bar Functionality
Summary
This PR addresses critical DNS resolution issues and enhances the progress bar functionality in RustScan, making it more stable and user-friendly.
🐛 Bug Fixes
🚀 Features & Enhancements
📊 Impact
🔧 Technical Details
📝 Changes
src/address.rs- Fixed DNS resolution logicsrc/scanner/mod.rs- Enhanced progress bar implementationThis is a backward-compatible improvement that addresses common user complaints about runtime crashes and missing progress indicators.