WIP: start on #23#25
Open
kingdonb wants to merge 1 commit intobeeminder:masterfrom
Open
Conversation
This is a start on addressing beeminder#23 which is to catch up this file with the attributes in the beeminder api reference
Author
|
I'm going to add the docu-strings and look at each new attr, then try to decide if it makes sense to be attr_reader or attr_accessor. Some of them are probably read-only, and others are user-configurable. If there are any "surprise, this one can't be written through the API" surprises in there that I should be careful of, please let me know! There is probably also testing around these attrs ? I haven't looked deeply enough at the change to see for sure, but I'll follow all of this up before I remove the "WIP" tag from the title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a start on addressing #23 which is to catch up this file with the attributes in the beeminder api reference.
I did some reordering so that it would be clearer at-a-glance that the list is the same as the one in Goal Resource
I noticed that "panic", "user", and possibly some others are not in the list under goal reference. I wonder if this is an omission from the API reference, or if there's something else going on here.
User I could understand if it was omitted because it is part of the RESTful route, so maybe it makes sense to remain in the list but shouldn't be counted? But panic seems like an attribute that is in use in several places in the gem, it seems like it probably hasn't been removed.