Draft: Upgrade gradle-wrapper to version 5.0 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gradle version 4.8, defining a custom wrapper or init task is deprecated. https://docs.gradle.org/4.8/release-notes.html#overwriting-gradle's-built-in-tasks Signed-off-by: Pierre-Louis Palant <palant@byte-lab.com>
This allows building using jdk 11. Signed-off-by: Pierre-Louis Palant <palant@byte-lab.com>
Update gradle wrapper
PL4typus
changed the title
Author
|
There are a lot more issues than I thought there would be, as other plugins/dependencies & even html tags in documentations have become deprecated. |
Owner
|
@PL4typus Thanks for you P/R, I'm just figuring out myself the issue. I'm currently adding support for php8.0 in soluble-japha and pjbserver-tools
Any chance you would work more on that ? PS/ did some work here: #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
This PR upgrades gradle-wrapper version to 5.0, allowing the project to be built using JDK 11.
It also removes deprecated built-in task overwrite. Gradle-wrrapper version should now be maintained only in
./gradle/wrapper/gradle-wrapper.properties