Implement std::error::Error for DialogResult and wrap hresult#8
Open
MarijnS95 wants to merge 1 commit intoben-wallis:masterfrom
Open
Implement std::error::Error for DialogResult and wrap hresult#8MarijnS95 wants to merge 1 commit intoben-wallis:masterfrom
std::error::Error for DialogResult and wrap hresult#8MarijnS95 wants to merge 1 commit intoben-wallis:masterfrom
Conversation
The current `DialogError` type makes it easy for downstream consumers to miss the error _reason_; some accidentally only printed `error_method` for example. And this makes it easier to propagate the error object upwards without additional re-wrapping. At the same time `std::io::Error` can help format `hresult` messages nicely using `from_raw_os_error()`. This error can also be returned out of `source()` to get a nice "backtrace" of what method caused this failure code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
See also native-dialog-rs/native-dialog-rs#76
The current
DialogErrortype makes it easy for downstream consumers to miss the error reason; some accidentally only printederror_methodfor example. And this makes it easier to propagate the error object upwards without additional re-wrapping.At the same time
std::io::Errorcan help formathresultmessages nicely usingfrom_raw_os_error(). This error can also be returned out ofsource()to get a nice "backtrace" of what method caused this failure code.