Skip to content

fix: skip model/API-key validation for oracle agent #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdotli merged 2 commits into from
Apr 21, 2026
Merged

fix: skip model/API-key validation for oracle agent #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30dbe21
fix: skip model/API-key validation for oracle agent
EYH0602 Apr 21, 2026
360c460
fix: don't assign default model to oracle agent
EYH0602 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/benchflow/cli/eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,12 @@ def _run_single(
from benchflow.sdk import SDK

sdk = SDK()
effective_model = None if agent == "oracle" else (model or DEFAULT_MODEL)
result = asyncio.run(
sdk.run(
task_path=task_dir,
agent=agent,
model=model or DEFAULT_MODEL,
model=effective_model,
environment=environment,
prompts=cast("list[str | None] | None", prompt),
agent_env=agent_env,
Expand Down Expand Up @@ -268,9 +269,10 @@ def _run_batch(
) -> None:
from benchflow.job import Job, JobConfig, RetryConfig

effective_model = None if agent == "oracle" else (model or DEFAULT_MODEL)
config = JobConfig(
agent=agent,
model=model or DEFAULT_MODEL,
model=effective_model,
environment=environment,
concurrency=concurrency,
retry=RetryConfig(max_retries=max_retries),
Expand Down
2 changes: 1 addition & 1 deletion src/benchflow/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class JobConfig:
"""Configuration for a benchmark job."""

agent: str = DEFAULT_AGENT
model: str = DEFAULT_MODEL
model: str | None = DEFAULT_MODEL
environment: str = "docker"
concurrency: int = 4
prompts: list[str | None] | None = None
Expand Down
Loading