Adding time handling to existing date filter input for format_string#7
Merged
benfaerber merged 1 commit intobenfaerber:masterfrom Apr 1, 2026
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
Owner
|
Nice! Thanks for the PR. Feel free to add more if you come up with any ideas / things that would help your use case. This will go out in the next release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! Apologies for the drive-by PR; no sweat if this isn't really what you're after :)
I am using Liquid_ml with a little static-site generator/blog thing to learn Ocaml, it's awesome! One thing I came across though is that the
input | dateformat seems to only acceptYYYY-MM-DDin, so I can't pass it a timestamp without constructing a Calendar and feeding it in as String:Now this is totally fine and again, probably what I'm expected to do here, but I thought I'd take a crack at adding time handling in for bare
String val's passed to Ctx and handed to the| datefilter as well!No expectation of this being merged or anything, I am very new to OCaml too so apologies if my code is crap as well, but figured I'd send a PR through in case this was at all useful to anyone else