Skip to content

Adding perf check to configure. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joerg84 wants to merge 1 commit into
base: ubuntu-14-04
Choose a base branch
from
Open

Adding perf check to configure. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/tests/environment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,41 @@ class NetcatFilter : public TestFilter
};


class PerfFilter : public TestFilter
{
public:
PerfFilter()
{
#ifdef __linux__
perfError = os::system("perf help >&-") != 0;
if (perfError) {
std::cerr
<< "-------------------------------------------------------------\n"
<< "No 'perf' command found so no 'perf' tests will be run\n"
<< "-------------------------------------------------------------"
<< std::endl;
}
#else
perfError = true;
#endif // __linux__
}

bool disable(const ::testing::TestInfo* test) const
{
// Currently all tests that require 'perf' are part of the
// 'PerfTest' test fixture, hence we check for 'Perf' here.
//
// TODO(ijimenez): Replace all tests which require 'perf' with
// the prefix 'PERF_' to be more consistent with the filter
// naming we've done (i.e., ROOT_, CGROUPS_, etc).
return matches(test, "Perf") && perfError;
}

private:
bool perfError;
};


class BenchmarkFilter : public TestFilter
{
public:
Expand Down Expand Up @@ -358,6 +393,7 @@ Environment::Environment(const Flags& _flags) : flags(_flags)
filters.push_back(Owned<TestFilter>(new BenchmarkFilter()));
filters.push_back(Owned<TestFilter>(new NetworkIsolatorTestFilter()));
filters.push_back(Owned<TestFilter>(new NetcatFilter()));
filters.push_back(Owned<TestFilter>(new PerfFilter()));

// Construct the filter string to handle system or platform specific tests.
::testing::UnitTest* unitTest = ::testing::UnitTest::GetInstance();
Expand Down