Adding pet_mode to set "indoor only" and "outdoor" to pets, fixes for duplicate feeders.#75
Open
bushbrother wants to merge 10 commits intobenleb:devfrom
Open
Adding pet_mode to set "indoor only" and "outdoor" to pets, fixes for duplicate feeders.#75bushbrother wants to merge 10 commits intobenleb:devfrom
bushbrother wants to merge 10 commits intobenleb:devfrom
Conversation
Added ability to set pets as "indoor only" or "outdoor"
|
Any idea on when this update will be merged and rolled out for the public? |
Collaborator
|
Hi, I've started to review this PR. I'll provide some comments soon |
|
Can't wait for this update to be merged ;-) |
|
@benleb seems to have abandoned this project ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added 2 new "modes" to pets, this allows them to be set as "indoor only" or "outdoor". I have also added this information to the pet attributes and created 2 services to call these methods. A new switch has been created to easily toggle the mode per pet. Finally I have attempted to fix the issue of the feeders constantly duplicating each time HA restarts, this looked to be due to unique IDs.
Please note this requires the surepy PR here: benleb/surepy#223