Skip to content

Fix current speaker selection and null fallback #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bennybrainless merged 1 commit into from
Dec 2, 2025
Merged

Fix current speaker selection and null fallback #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions discord/src/pages/dashboard/widgets/MiniCallWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ParticipantBox } from "@src/components/ParticipantBox";
import { useCallStore } from "@src/stores/callStore";
import { useRef, useEffect, useState, useMemo } from "react";
import { useRef, useEffect, useState } from "react";

export const MiniCallWidget = () => {
const callStatus = useCallStore((state) => state.callStatus);
Expand All @@ -13,17 +13,20 @@ export const MiniCallWidget = () => {
const [collapsed, setCollapsed] = useState(false);

const [lastSpeakerId, setLastSpeakerId] = useState<string | null>(null);
const participants = callStatus?.participants ?? [];

const currentSpeaker = useMemo(() => {
const talkingSpeaker = callStatus?.participants.find((p) => p.isSpeaking) || null;
if (talkingSpeaker) {
useEffect(() => {
if (!participants.length) return;

const talkingSpeaker = participants.find((p) => p.isSpeaking);
if (talkingSpeaker && talkingSpeaker.id !== lastSpeakerId) {
setLastSpeakerId(talkingSpeaker.id);
return talkingSpeaker;
} else if (lastSpeakerId) {
return callStatus?.participants.find((p) => p.id === lastSpeakerId) || null;
}
return null;
}, [callStatus]);
}, [participants, lastSpeakerId]);

const currentSpeaker =
participants.find((p) => p.isSpeaking) ||
(lastSpeakerId ? participants.find((p) => p.id === lastSpeakerId) || null : null);


// Mouse drag handlers
Expand Down Expand Up @@ -87,7 +90,8 @@ export const MiniCallWidget = () => {
};
}, [dragging, offset]);

if (!currentSpeaker) return
if (!participants.length) return null;
if (!currentSpeaker) return null;


return (
Expand Down