Skip to content

Conversation

@stofel
Copy link

@stofel stofel commented Oct 31, 2015

Hi, i add maps support by add couchbeam:open_doc(Db, DocId, Options), Options = [return_maps]
Work, but not heavy tested

@stofel
Copy link
Author

stofel commented Nov 1, 2015

Add ifdef(MAP_SUPPORT) help to pass the tests?
How to be with jsx dependecy which should be updated to version with maps support?

@stofel
Copy link
Author

stofel commented Nov 1, 2015

Also need add to documentation:
For maps support add to rebar.config
{erl_opts, [{d, 'MAPS_SUPPORT'}]}.

@benoitc
Copy link
Owner

benoitc commented Nov 4, 2015

@stofel what do you mean by How to be with jsx dependecy which should be updated to version with maps support? is upgrading the dependency enough?

About tests, they should be upgraded to unit or ct, but waiting that what would be the best way to rerun them <ith maps support? Any idea?

@stofel
Copy link
Author

stofel commented Nov 4, 2015

My mistake, jsx is ok.
add {erl_opts, [{d, 'MAPS_SUPPORT'}]} to rebar.config get test passed? but its becouse new code not tested :)

@benoitc
Copy link
Owner

benoitc commented Nov 4, 2015

@stofel couchbeam 1.2.1 is released. Tests are now using eunit. It should be feasible to test both by looping over them. Hopefully we can have it in another release this week :)

Aleksey S. Kluchnikov added 2 commits November 5, 2015 08:36
@stofel
Copy link
Author

stofel commented Nov 5, 2015

rebar3 eunit ignore ifdefs. I dont know how to resolve this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants