Add macos-arm64 arch#41
Merged
benweissmann merged 5 commits intobenweissmann:masterfrom Apr 6, 2025
Nevalicjus:master
Merged
Conversation
benweissmann
requested changes
Apr 6, 2025
Owner
benweissmann
left a comment
benweissmann
left a comment
There was a problem hiding this comment.
Thank you for this contribution! I have one small request, but other than that this looks great.
index.sh
Outdated
| "darwin") | ||
| case "$machine" in | ||
| "arm64") platform='macos-arm64' ;; | ||
| "x86_64") platform='osx' ;; |
Owner
There was a problem hiding this comment.
Since I don't have a pre-M1 machine handy to test this fallback on -- let's have this branch use *) platform='osx' ;; instead of specifically matching x86_64 so we guarantee no change in behavior unless uname -m reports arm64.
Contributor
Author
There was a problem hiding this comment.
I was indeed torn between * and x86_64 case for osx, but finally decided on x86_64 to match the other precisely defined cases - but I do think that would be more reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My pr adds support for macos-arm64 release, so micro installed via the script doesn't require rosetta to run.
I've also modified the test workflow to run on macos-13 and macos-14 instead of just macos-12.
I've also added
macos-arm64as a valid release in both the error message and readme (respecting the alphabetical order).How Has This Been Tested?
I've ran the updated script on an intel mac and on an arm mac, and it worked.
My changes have also passed existing tests.
Checklist: