Open
Conversation
kaytijackson97
left a comment
kaytijackson97
left a comment
There was a problem hiding this comment.
Well done converting those components into functional components! Remember that you can import useState and other hooks from react to clean up your code and to keep good indentation. Also you can clean up the extra commented out lines of code since you will no longer be needing them. Keep up the good work!
| const isCorrectGuess = this.state.latestGuess === this.state.numberToGuess; | ||
|
|
||
| function NumberGuessingGame() { | ||
| const[numberToGuess, setNumberToGuess]= React.useState(getRandomNumber()); |
There was a problem hiding this comment.
You can import useState from React to prevent writing React.useState everytime
| const[numberToGuess, setNumberToGuess]= React.useState(getRandomNumber()); | ||
| const[numberOfGuesses, setNumberOfGuesses]= React.useState(0); | ||
| const[latestGuess, setLatestGuess]= React.useState(null); | ||
| function handleGuess(guess) { |
There was a problem hiding this comment.
indentation of handleGuess and handleReset should match state variables
| } | ||
| // /** | ||
| // * These lines are required to make the methods/functions declared on this | ||
| // * class have the correct `this` object when they run. |
There was a problem hiding this comment.
can remove the commented out lines of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.