implement ADSHardware.__del__ to clean up open WF_SDK references#3
Open
leigh-johnson wants to merge 2 commits intoberkeley-physics111a:mainfrom
Open
implement ADSHardware.__del__ to clean up open WF_SDK references#3leigh-johnson wants to merge 2 commits intoberkeley-physics111a:mainfrom
leigh-johnson wants to merge 2 commits intoberkeley-physics111a:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
I moved
ADSHardwaredefinitions into a module so I didn't have to patch this in two places. Let me know if there was a reason ADSHardware was duplicated and this needs to be reverted. Otherwise, squash + merge at will.I also enabled more verbose traceback on SIGSEGV (seg fault) signals, for follow-up (if needed).