don't kick if data rate is at threshold

[HarvsG]

Fixes #231

[Flole998]

@PolynomialDivision Can this be merged please?

[PolynomialDivision]

I don't understand the benefit? You can just set the threshold to a higher value and it has the same effect?

[Flole998]

I just checked the docs again and they describe the current behaviour. However, the log entry is misleading then as it says "below" while it should say "at or below". @HarvsG What do you think about just changing the log message?

[HarvsG]

Current behaviour is broken, because the default setting is a commonly used data rate, so clients are kicked uneccessarily

[teohhanhui]

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

DAWN/src/storage/datastorage.c

Line 566 in e036905

// <= 6MBits <- probably no transmission

[HarvsG]

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

I don't think it's a safe assumption because some IoT devices do transmit at that data rate.

[felipecrs]

@PolynomialDivision I think this PR is a no-brainer. The log message says "below limit" while it's not in fact below. Maybe you can reconsider it?

[HarvsG]

@PolynomialDivision I think this PR is a no-brainer. The log message says "below limit" while it's not in fact below. Maybe you can reconsider it?

An alternative (and non-breaking) change would be to change the log statement to say "Equal to or below limit".

[PolynomialDivision]

Superseded by #248